profiles: use single sample_type per Profile #610
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each
message Profile
should hold only a single kind ofsample_type
. This allows easier, parallel and more directed processing of eachmessage Profile
.Still, a single OTel profiling protocol message can have multiple
message Profile
each with its individualsample_type
. This lifts the limitation from the original pprof format, where a singlemessage Profile
can and needs to be able to hold different kinds of samples, as it does not have an enveloping message likemessage ScopeProfiles
in the OTel profiling protocol.ping @open-telemetry/profiling-maintainers @jhalliday